Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring what command to use for running composer in the artifact #110

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Allow configuring what command to use for running composer in the artifact #110

merged 3 commits into from
Nov 13, 2018

Conversation

becw
Copy link
Member

@becw becw commented Oct 18, 2018

Resolves #23 -- though it requires that you add a bit of configuration if you don't have the composer or composer.phar commands available globally.

@becw becw requested a review from byrond October 18, 2018 23:54
@becw becw assigned becw and byrond Oct 18, 2018
@becw becw added this to the 2.0 milestone Oct 18, 2018
byrond
byrond reviewed Nov 5, 2018
View reviewed changes
Copy link
Contributor

@byrond byrond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and I was able to do some testing to verify that it works with a couple changes. I just had a question about dependencies and comment, but maybe the way I tested wasn't similar to how this would be used.

defaults.properties.yml Outdated Show resolved Hide resolved
@becw becw merged commit e63d360 into release-2.0 Nov 13, 2018
@becw becw deleted the use-phing-composertask branch November 13, 2018 16:19
@becw becw mentioned this pull request Nov 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrond byrond byrond left review comments

Assignees

@becw becw

@byrond byrond

Labels
Ready for Review
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@becw @byrond